[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_local_host refactoring to return a promise #65

Merged
merged 6 commits into from
Jan 5, 2022
Merged

is_local_host refactoring to return a promise #65

merged 6 commits into from
Jan 5, 2022

Conversation

DoobleD
Copy link
Contributor
@DoobleD DoobleD commented Jan 2, 2022

Refactors is_local_host to use promises.

This makes its use easier in Haraka/outbound/mx_lookup.js, though I'm not sure this complies with the project code guidelines as I haven't seen use of promises elsewhere in it so far.

@DoobleD DoobleD mentioned this pull request Jan 2, 2022
Merged
3 tasks
@DoobleD DoobleD mentioned this pull request Jan 2, 2022
Merged
3 tasks
@msimerson
Copy link
Member

Looks fine, please also bump the version number and update Changes.md.

@DoobleD
Copy link
Contributor Author
DoobleD commented Jan 4, 2022

Looks fine, please also bump the version number and update Changes.md.

Thanks for the feedback @msimerson. It's done. I've also updated the required version of haraka-net-utils in haraka/Haraka#3010 but that seems to break the CI on that PR. Should I remove the last commit there?

@msimerson
Copy link
Member

Should I remove the last commit there?

Nah, after publishing this version that test will pass.

@msimerson
Copy link
Member

Your test addition is sometimes failing:

Screen Shot 2022-01-04 at 12 29 57 PM

Unfortunately, DNS within GHA (and Travis before) is sometimes less than speedy. We've learned by trial and error to not introduce too many DNS tests.

@DoobleD
Copy link
Contributor Author
DoobleD commented Jan 5, 2022

Your test addition is sometimes failing:

Screen Shot 2022-01-04 at 12 29 57 PM

Unfortunately, DNS within GHA (and Travis before) is sometimes less than speedy. We've learned by trial and error to not introduce too many DNS tests.

Thanks @msimerson, makes sense, I've just removed the faulty test.

@msimerson msimerson merged commit 67f322e into haraka:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DoobleD @msimerson