Fixes issue in the outbound local mx check introduced in #3002 #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoobleD
commented
Jan 2, 2022
|
This pull request introduces 4 alerts when merging ea9398f into 786daac - view on LGTM.com new alerts:
|
Fixed. |
3 tasks
DoobleD
commented
Jan 5, 2022
msimerson
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3002 (comment).
Changes proposed in this pull request:
process_dnsasyncawaitin front ofis_local_hostRequires haraka/haraka-net-utils#65 to be merged, as that PR refactors
is_local_hostto use promises.Alternatively it should be possible to use callbacks only, but it seems to me the code is much simpler using promises.
Checklist: