UI: Update template helpers and cleanup component args #30580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Results: |
hellobontempo
commented
May 12, 2025
| * | ||
| * */ | ||
|
|
||
| interface Args { | ||
| authTabData: AuthTabData; | ||
| canceledMfaAuth: string; |
hellobontempo
commented
May 12, 2025
| @@ -50,15 +50,14 @@ | |||
| /> | |||
| {{else}} | |||
| <Auth::FormTemplate | |||
| @authTabData={{this.authTabData}} | |||
| @canceledMfaAuth={{this.canceledMfaAuth}} | |||
|
CI Results: |
hellobontempo
commented
May 12, 2025
| @@ -185,7 +183,7 @@ module('Integration | Component | auth | form template', function (hooks) { | |||
| test('it renders the mount description', async function (assert) { | |||
| await this.renderComponent(); | |||
| await click(AUTH_FORM.tabBtn('token')); | |||
| assert.dom('section p').hasText('token based credentials data-test-description'); | |||
hellobontempo
commented
May 12, 2025
There was a problem hiding this comment.
Renamed to mounts-display and now this renders either the dropdown or a single mount input
hellobontempo
commented
May 12, 2025
| {{else}} | ||
| {{! render a single mount path }} | ||
| {{#let (get @mounts "0") as |mount|}} | ||
| {{#unless @hideType}} |
There was a problem hiding this comment.
This component doesn't always render within the login form tabs, so sometimes we'll want to render the type here
hellobontempo
commented
May 12, 2025
| {{! URL contains a "with" query param that references a mount with listing_visibility="unauth" }} | ||
| {{! Treat it as a "preferred" mount and hide all other tabs }} | ||
| <Auth::MountsDisplay | ||
| @mounts={{array @directLinkData}} |
There was a problem hiding this comment.
went back and forth on whether I should also pass in a @mount (singular) arg but keeping the type consistent and always passing an array of mount objects seemed the most straightforward.
|
|
beagins
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prep work for implementing custom login feature.
Auth::SingleMountto display mount data in general which could be a single mount or multiple.displayNamehelper globalTODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.