8000 Add ProjectionNode before `SELECT DISTINCT` AggregateNode if necessary by dey4ss · Pull Request #2571 · hyrise/hyrise · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ProjectionNode before SELECT DISTINCT AggregateNode if necessary 8000 #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2023
Merged

Add ProjectionNode before SELECT DISTINCT AggregateNode if necessary #2571

merged 4 commits into from
Jun 19, 2023

Conversation

dey4ss
Copy link
Member
@dey4ss dey4ss commented Jun 5, 2023 •
edited
Loading

While working on the SQL translation of window functions, I noticed we do not handle SELECT DISTINCT statements correctly if there were further operations on the selected columns (see #2570). This PR fixes this issue and makes Hyrise behave consistent to Postgres in these cases.

closes #2570

@dey4ss dey4ss added ReallyEasyToReview FullCI Run all CI tests (slow, but required for merge) labels Jun 5, 2023
@dey4ss dey4ss requested a review from Bouncner June 5, 2023 21:11
@dey4ss dey4ss mentioned this pull request Jun 8, 2023
Merged
Bouncner
Bouncner reviewed Jun 10, 2023
View reviewed changes
@dey4ss dey4ss merged commit 89e46b6 into master Jun 19, 2023
@dey4ss dey4ss deleted the dey4ss/add_projections_before_distinct branch June 19, 2023 13:02
nikriek pushed a commit that referenced this pull request Oct 28, 2023
@dey4ss @nikriek
Add ProjectionNode before SELECT DISTINCT AggregateNode if necessary (
e0788a1 
#2571)

Handle `SELECT DISTINCT` statements correctly if there are further operations on the selected columns.
nikriek pushed a commit that referenced this pull request Nov 6, 2023
@dey4ss @nikriek
Add ProjectionNode before SELECT DISTINCT AggregateNode if necessary (
7ad16f7 
#2571)

Handle `SELECT DISTINCT` statements correctly if there are further operations on the selected columns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bouncner Bouncner Bouncner approved these changes

Assignees
No one assigned
Labels
FullCI Run all CI tests (slow, but required for merge) ReallyEasyToReview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SELECT DISTINCT does not work on Projections
2 participants
@dey4ss @Bouncner
0