Parse and represent window fun 8000 ctions in the LQP #2574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Bouncner
reviewed
Jun 26, 2023
Bouncner
reviewed
Jul 11, 2023
| @@ -289,6 +292,27 @@ std::shared_ptr<TableStatistics> CardinalityEstimator::estimate_projection_node( | |||
| return std::make_shared<TableStatistics>(std::move(column_statistics), input_table_statistics->row_count); | |||
| } | |||
|
|
|||
| std::shared_ptr<TableStatistics> CardinalityEstimator::estimate_window_node( | |||
| const WindowNode& window_node, const std::shared_ptr<TableStatistics>& input_table_statistics) const { | |||
| // For the result of the window function, dummy statistics are created for now. | |||
There was a problem hiding this comment.
Never said they are always going to be distinct. I thought about a fair assumption for cardinality estimations. In most cases, it will be distinct (I'd guess) and in other cases, we do at least not underestimate. But nevermind ... probably not relevant for now.
| // NOLINTNEXTLINE - while this particular method could be made static, others cannot. | ||
| std::shared_ptr<AbstractOperator> LQPTranslator::_translate_window_node( | ||
| const std::shared_ptr<AbstractLQPNode>& node) const { | ||
| FailInput("Hyrise does not yet support window functions."); |
There was a problem hiding this comment.
Nothing for this PR, yes. But I wanted to note it somewhere to discuss it after the vacations.
This was referenced Jul 27, 2023
16 tasks
nikriek
pushed a commit
that referenced
this pull request
Oct 28, 2023
Add the representation of SQL:2003 window functions in the LQP, including the translation in the SQLTranslator.
nikriek
pushed a commit
that referenced
this pull request
Nov 6, 2023
Add the representation of SQL:2003 window functions in the LQP, including the translation in the SQLTranslator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Bouncner you want it, you get it 🖤
This PR adds the representation of SQL:2003 window functions in the LQP. This includes the translation in the SQLTranslator.
Changes are:
sum,min,avg, etc.), it is a regular aggregate expression.visualizecommand.Note that this is branched off #2571, so this PR currently also includes its diff.