8000 add support for axis illustration files in push.py by zhaoxiong0211 · Pull Request #532 · googlefonts/gftools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add support for axis illustration files in push.py #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from 8000
Apr 5, 2022
Merged

add support for axis illustration files in push.py #532

merged 4 commits into from
Apr 5, 2022

Conversation

zhaoxiong0211
Copy link
Contributor

No description provided.

m4rc1e
m4rc1e reviewed Apr 5, 2022
View reviewed changes
@m4rc1e
Copy link
Collaborator
m4rc1e commented Apr 5, 2022

Apologies but I'm not aware of what you're working on. Are we adding illustrations for each axis? will they be visible on fonts.google.com?

@zhaoxiong0211
Copy link
Contributor Author

Apologies but I'm not aware of what you're working on. Are we adding illustrations for each axis? will they be visible on fonts.google.com?

sorry i should have linked this PR. https://github.com/google/fonts/pull/4470/files
We are aiming to add illustration to each axis and it shall be shown to users together with the description

@m4rc1e
Copy link
Collaborator
m4rc1e commented Apr 5, 2022

Ok cool. I'm happy with this pr.

We currently have two axis registries which is not ideal. One in google/fonts, the other over at https://github.com/googlefonts/axisregistry. @felipesanches recently made the latter. @zhaoxiong0211 would it be possible to also add your google/fonts pr to this repo? Ideally, we should drop the axis registry in google/fonts and just use the repo in the future.

@zhaoxiong0211
Copy link
Contributor Author

Definitely. I'll make the changes in https://github.com/googlefonts/axisregistry later. Thank you @m4rc1e for the notice!

@zhaoxiong0211
Copy link
Contributor Author

PR in googlefonts/axisregistry
googlefonts/axisregistry#29

@zhaoxiong0211 zhaoxiong0211 merged commit b5475ef into main Apr 5, 2022
@zhaoxiong0211 zhaoxiong0211 mentioned this pull request Apr 6, 2022
Merged
@m4rc1e m4rc1e deleted the zx_illustration branch April 7, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e m4rc1e left review comments

@nathan-williams nathan-williams nathan-williams approved these changes

@andyjgf andyjgf Awaiting requested review from andyjgf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaoxiong0211 @m4rc1e @nathan-williams
0