add illustration url to axis.textproto #4470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-williams
approved these changes
Apr 5, 2022
|
Will also need to push these to the split out repo :)
|
Done at googlefonts/axisregistry#29 |
|
@m4rc1e hey Marc, did you happen to know why https://github.com/google/fonts/runs/5849631184?check_suite_focus=true fails even I have googlefonts/gftools#532 merged? Did I need to do something to get the test file updated? Thanks |
|
I need to cut a new release of gftools. I'll do that for you now. |
|
That's amazing. Thank you Marc. :) |
|
Np. Thank you for using our CI and updating it. |
|
Yep, ci is now passing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.