8000 fix(deps): update dependency protobufjs to ~7.2.0 [security] by renovate-bot · Pull Request #254 · google/pprof-nodejs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(deps): update dependency protobufjs to ~7.2.0 [security] #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

renovate-bot
Copy link
Contributor
@renovate-bot renovate-bot commented Jul 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
protobufjs (source) ~7.0.0 -> ~7.2.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-36665

protobuf.js (aka protobufjs) 6.10.0 until 7.2.4 allows Prototype Pollution, a different vulnerability than CVE-2022-25878. A user-controlled protobuf message can be used by an attacker to pollute the prototype of Object.prototype by adding and overwriting its data and functions. Exploitation can involve: (1) using the function parse to parse protobuf messages on the fly, (2) loading .proto files by using load/loadSync functions, or (3) providing untrusted input to the functions ReflectionObject.setParsedOption and util.setProperty. NOTE: this CVE Record is about Object.constructor.prototype.<new-property> = ...; whereas CVE-2022-25878 was about Object.__proto__.<new-property> = ...; instead.


Release Notes

protobufjs/protobuf.js (protobufjs)

v7.2.4

Compare Source

Bug Fixes

v7.2.3

Compare Source

Bug Fixes

v7.2.2

Compare Source

Bug Fixes
  • do not allow to extend same field twice to prevent the error (#​1784) (14f0536)

v7.2.1

Compare Source

Bug Fixes

v7.2.0

Compare Source

Features
  • cli: generate static files at the granularity of proto messages (#​1840) (32f2d6a)
Bug Fixes

v7.1.2

Compare Source

Bug Fixes

v7.1.1

Compare Source

Bug Fixes

v7.1.0

Compare Source

Features
Bug Fixes

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@aabmass
Copy link
Member
aabmass commented Jul 18, 2023

It looks like the protobuf type definitions just need to be regenerated

@codeco
8000
v-commenter
Copy link
codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #254 (48b413b) into main (b945686) will decrease coverage by 0.27%.
The diff coverage is 48.14%.

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   42.21%   41.94%   -0.27%     
==========================================
  Files          14       14              
  Lines        2061     2093      +32     
  Branches       42       42              
==========================================
+ Hits          870      878       +8     
- Misses       1173     1197      +24     
  Partials       18       18              
Impacted Files Coverage Δ
proto/profile.js 23.55% <48.14%> (+0.03%) ⬆️

@aabmass aabmass linked an issue Jul 20, 2023 that may be closed by this pull request
@aabmass aabmass requested a review from psx95 July 20, 2023 04:00
@aabmass aabmass self-requested a review July 20, 2023 04:03
@aabmass aabmass force-pushed the renovate/npm-protobufjs-vulnerability branch from 48acf49 to d542e91 Compare July 20, 2023 04:03
@forking-renovate
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@aabmass aabmass removed their request for review July 20, 2023 14:48
@aabmass aabmass merged commit 787c526 into google:main Jul 20, 2023
aabmass added a commit to aabmass/pprof-nodejs that referenced this pull request Jul 21, 2023
)

* fix(deps): update dependency protobufjs to ~7.2.0 [security]

* Pull in protobufjs-cli tools (pbjs and pbts) and regen proto stubs

* Explicitly upgrade protobufjs past vulnerability, regenerate package-lock.json

---------

Co-authored-by: Aaron Abbott <aaronabbott@google.com>
aabmass added a commit to aabmass/pprof-nodejs that referenced this pull request Jul 21, 2023
)

* fix(deps): update dependency protobufjs to ~7.2.0 [security]

* Pull in protobufjs-cli tools (pbjs and pbts) and regen proto stubs

* Explicitly upgrade protobufjs past vulnerability, regenerate package-lock.json

---------

Co-authored-by: Aaron Abbott <aaronabbott@google.com>
aabmass added a commit that referenced this pull request Jul 21, 2023
* chore(deps): update golang docker tag to v1.17 (#182)

* test: change base Debian image from Debian 9 to Debian 11 to include a supported Python3 version for node-gyp (#187)

* fix(deps): update dependency protobufjs to ~7.2.0 [security] (#254)

* fix(deps): update dependency protobufjs to ~7.2.0 [security]

* Pull in protobufjs-cli tools (pbjs and pbts) and regen proto stubs

* Explicitly upgrade protobufjs past vulnerability, regenerate package-lock.json

---------

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Update package-lock so there are no prod vulnerabilities

* chore(deps): update dependency sinon to v15 (#237)

* npm run fix with new package-lock.json

* chore: remove testing in windows from workflow (#202)

* Fix system test to use older npm for compat

* test: bump debian version in system test (#251)

* test: specify python3 when building docker image (#192)

* Use alpine version with python < 3.11

---------

Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Garrett Wang <garrettwang@google.com>
Co-authored-by: Amarin (Um) Phaosawasdi <amchiclet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2023-36665 vunerablity in protobufjs >= 6.10.0, < 7.2.4
5 participants
0