test: change base Debian image from Debian 9 to Debian 11 to include a supported Python3 version for node-gyp #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nolanmar511 , are there any other tests other than Github Actions I need to run to make sure this PR works as intended? |
nolanmar511
approved these changes
Oct 12, 2021
|
The Kokoro tests will run automatically on each new commit. It looks like one fails. I think changing "python3" to "python3.6" on this line would likely let the failing test pass. |
nolanmar511
approved these changes
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 42.21% 42.21%
=======================================
Files 14 14
Lines 2061 2061
Branches 42 42
=======================================
Hits 870 870
Misses 1173 1173
Partials 18 18 Continue to review full report at Codecov.
|
nolanmar511
approved these changes
Oct 14, 2021
aabmass
pushed a commit
to aabmass/pprof-nodejs
that referenced
this pull request
Jul 21, 2023
…a supported Python3 version for node-gyp (google#187)
aabmass
pushed a commit
to aabmass/pprof-nodejs
that referenced
this pull request
Jul 21, 2023
…a supported Python3 version for node-gyp (google#187)
aabmass
added a commit
that referenced
this pull request
Jul 21, 2023
* chore(deps): update golang docker tag to v1.17 (#182) * test: change base Debian image from Debian 9 to Debian 11 to include a supported Python3 version for node-gyp (#187) * fix(deps): update dependency protobufjs to ~7.2.0 [security] (#254) * fix(deps): update dependency protobufjs to ~7.2.0 [security] * Pull in protobufjs-cli tools (pbjs and pbts) and regen proto stubs * Explicitly upgrade protobufjs past vulnerability, regenerate package-lock.json --------- Co-authored-by: Aaron Abbott <aaronabbott@google.com> * Update package-lock so there are no prod vulnerabilities * chore(deps): update dependency sinon to v15 (#237) * npm run fix with new package-lock.json * chore: remove testing in windows from workflow (#202) * Fix system test to use older npm for compat * test: bump debian version in system test (#251) * test: specify python3 when building docker image (#192) * Use alpine version with python < 3.11 --------- Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Garrett Wang <garrettwang@google.com> Co-authored-by: Amarin (Um) Phaosawasdi <amchiclet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.