server: Use slice of Certificates instead of a CertPool #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmwu
approved these changes
Apr 5, 2022
This makes the API easier to call and simplifies our code. This is a **breaking** change. Signed-off-by: Joe Richey <joerichey@google.com>
jessieqliu
approved these changes
Apr 5, 2022
jessieqliu
pushed a commit
that referenced
this pull request
Apr 6, 2022
This makes the API easier to call and simplifies our code. This is a **breaking** change. Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
added a commit
that referenced
this pull request
Apr 10, 2022
- Use `[]*x509.Certificate` instead of `x509.CertPool` in `VerifyOptions`: #185 - Enable AK Intermediate fetching in the launcher: #177 - Remove `github.com/google/certificate-transparency-go/x509` dependancy: < 8000 a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1178881743" data-permission-text="Title is private" data-url="https://github.com/google/go-tpm-tools/issues/178" data-hovercard-type="pull_request" data-hovercard-url="/google/go-tpm-tools/pull/178/hovercard" href="https://github.com/google/go-tpm-tools/pull/178">#178 - Add "tee-impersonate-service-accounts" to launcher: #182 - Get instance information from AK Certificate: #184 - Move to using Go 1.18 Workspaces: #176 #180 - Update documentation for building `gotpm` CLI: #181 Signed-off-by: Joe Richey <joerichey@google.com>
Merged
josephlr
added a commit
that referenced
this pull request
Apr 11, 2022
- Use `[]*x509.Certificate` instead of `x509.CertPool` in `VerifyOptions`: #185 - Enable AK Intermediate fetching in the launcher: #177 - Remove `github.com/google/certificate-transparency-go/x509` dependancy: #178 - Add "tee-impersonate-service-accounts" to launcher: #182 - Get instance information from AK Certificate: #184 - Move to using Go 1.18 Workspaces: #176 #180 - Update documentation for building `gotpm` CLI: #181 Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the API easier to call and simplifies our code.
This is a breaking change.
Signed-off-by: Joe Richey joerichey@google.com