-
Notifications
You must be signed in to change notification settings - Fork 75
Retrieve instance info from AK certificate #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
requested changes
Apr 6, 2022
@jessieqliu can you also fix the conflicts? |
4f01393
to
71eff4f
Compare
alexmwu
reviewed
Apr 6, 2022
Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
approved these changes
Apr 7, 2022
josephlr
added a commit
that referenced
this pull request
Apr 10, 2022
- Use `[]*x509.Certificate` instead of `x509.CertPool` in `VerifyOptions`: #185 - Enable AK Intermediate fetching in the launcher: #177 - Remove `github.com/google/certificate-transparency-go/x509` dependancy: #178 - Add "tee-impersonate-service-accounts" to launcher: #182 - Get instance information from AK Certificate: #184 - Move to using Go 1.18 Workspaces: #176 #180 - Update documentation for building `gotpm` CLI: #181 Signed-off-by: Joe Richey <joerichey@google.com>
Merged
josephlr
added a commit
that referenced
this pull request
Apr 11, 2022
- Use `[]*x509.Certificate` instead of `x509.CertPool` in `VerifyOptions`: #185 - Enable AK Intermediate fetching in the launcher: #177 - Remove `github.com/google/certificate-transparency-go/x509` dependancy: #178 - Add "tee-impersonate-service-accounts" to launcher: #182 - Get instance information from AK Certificate: #184 - Move to using Go 1.18 Workspaces: #176 #180 - Update documentation for building `gotpm` CLI: #181 Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After validating the AK certificate, look for an extension with a specific ObjectIdentifier that contains GCE instance information and return it in a MachineState.