Allow EXT-OATCLS-SCTE35 on non CUE-OUT segments #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandromoreira
approved these changes
Jun 17, 2024
| output.append("#EXT-X-CUE-IN\n") | ||
| elif self.oatcls_scte35: | ||
| output.append(f"{ext_oatcls_scte35}:{self.oatcls_scte35}\n") |
There was a problem hiding this comment.
Thank you for using f strings
mauricioabreu
approved these changes
Jun 19, 2024
|
Thanks! Looking forward to this being released. |
|
@bbayles I'm going to release a new version later today. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #85 and #290, support for
EXT-OATCLS-SCTE35tags was added - these are used by Elemental and some others.Currently, this library only supports
EXT-OATCLS-SCTE35tags on segments that in a "cue out" state. However, they are often used outside of that context as well - I've added an example playlist to the test suite.This PR updates the support for these tags to allow them to flow through even if they aren't associated with a "cue out."