Persist EXT-OATCLS-SCTE35 in Segment.dumps #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
commented
Aug 1, 2022
| @@ -111,10 +111,13 @@ def parse(content, strict=False, custom_tags_parser=None): | |||
| state['cue_out'] = True | |||
|
|
|||
| elif line.startswith(protocol.ext_x_cue_out): | |||
| _parse_cueout(line, state, string_to_lines(content)[lineno - 2]) | |||
| _parse_cueout(line, state) | |||
There was a problem hiding this comment.
This change allowed me to simplify "cue out" parsing. We no longer require the "previous line" to be examined.
There was a problem hiding this comment.
You are right! Much better.
bbayles
commented
Aug 1, 2022
| @@ -25,7 +25,7 @@ | |||
| ext_x_cue_out_cont = '#EXT-X-CUE-OUT-CONT' | |||
| ext_x_cue_in = '#EXT-X-CUE-IN' | |||
| ext_x_cue_span = '#EXT-X-CUE-SPAN' | |||
| ext_x_scte35 = '#EXT-OATCLS-SCTE35' | |||
There was a problem hiding this comment.
EXT-X-SCTE35 is actually a different tag. It's specified in this document.
| @@ -6,7 +6,13 @@ | |||
| 8000 | import os | ||
| import errno | |||
|
|
|||
| from m3u8.protocol import ext_x_start, ext_x_key, ext_x_session_key, ext_x_map | |||
| from m3u8.protocol import ( | |||
mauricioabreu
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances support for SCTE-35 enhanced manifests.
Segment.oatcls_scte35is now set forSegments with aEXT-OATCLS-SCTE35tag. That property is also set forSegments in the sameEXT-X-CUE-OUTtoEXT-X-CUE-INblock.Segment.dumpsnow preservesEXT-OATCLS-SCTE35as well.Fixes #183