Pp 1150 i os invoice user fü education concept #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, QREducationLoadingController, Resources PP-1150
…Controller PP-1150
…150-iOS-QR-code-User-FÜ-Education-concept
…ply renames PP-1150
…bels & accessibility PP-1150
There was a problem hiding this comment.
@mrkulik I left a small suggestion. Thank you!
I also think that we can still work on naming, but we can do this later.
.../Sources/GiniCaptureSDK/Core/Screens/Analysis/QREducation/QREducationLoadingController.swift
Outdated
Show resolved
Hide resolved
…message display logic PP-1221
… CaptureSDK PP-1221
…ow using EducationFlowController (1 message, max 2 times) PP-1221
…lag into UserDefaultsStorage from CaptureSDK PP-1221
…boarding flag instead of direct `UserDefaults` access - Replaced raw UserDefaults calls with `GiniCaptureUserDefaultsStorage.onboardingShowed` - Simplified onboarding flag logic with property wrapper abstraction - Ensures consistent UserDefaults key management PP-1221
…r onboarding flag instead of direct `UserDefaults` access PP-1221
…ice and if `qrCodeEducationEnabled` is true - exclude import of files: pdfs or images/gifs PP-1221
…te animation completion PP-1221
…. view binding PP-1150
…isViewController PP-1150
…Analysis screen completes via `performWhenAnimationCompleted` PP-1221
…Item, remove extension from viewModel PP-1150
…1221-Implement-local-storage-for-the-client-configuration-flag-and-logic-to-display-the-message # Conflicts: # CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Analysis/AnalysisViewController.swift # CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Analysis/QREducation/QREducationLoadingController.swift
PP-1221
- improve the documentation PP-1221
…-the-client-configuration-flag-and-logic-to-display-the-message Pp 1221 implement local storage for the client configuration flag and logic to display the message
| // | ||
|
|
||
| import Foundation | ||
| import Combine |
There was a problem hiding this comment.
@mrkulik can you please remove this? I forgot to do it in my branch which was merged into this. Thank you!
There was a problem hiding this comment.
I did it :D . Thank you!
ValentinaIancu-Gini
approved these changes
May 12, 2025
f4beec4
into
GiniBankSDK-release-3.16.0-qr-code-education
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.