-
Notifications
You must be signed in to change notification settings - Fork 3
Pp 1221 implement local storage for the client configuration flag and logic to display the message #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ValentinaIancu-Gini
merged 21 commits into
PP-1150-iOS-QR-code-User-FÜ-Education-concept
from
PP-1221-Implement-local-storage-for-the-client-configuration-flag-and-logic-to-display-the-message
May 9, 2025
Merged
Pp 1221 implement local storage for the client configuration flag and logic to display the message #859
ValentinaIancu-Gini
merged 21 commits into
PP-1150-iOS-QR-code-User-FÜ-Education-concept
from
PP-1221-Implement-local-storage-for-the-client-configuration-flag-and-logic-to-display-the-message
May 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…message display logic PP-1221
… CaptureSDK PP-1221
…ow using EducationFlowController (1 message, max 2 times) PP-1221
…lag into UserDefaultsStorage from CaptureSDK PP-1221
…boarding flag instead of direct `UserDefaults` access - Replaced raw UserDefaults calls with `GiniCaptureUserDefaultsStorage.onboardingShowed` - Simplified onboarding flag logic with property wrapper abstraction - Ensures consistent UserDefaults key management PP-1221
…r onboarding flag instead of direct `UserDefaults` access PP-1221
…ice and if `qrCodeEducationEnabled` is true - exclude import of files: pdfs or images/gifs PP-1221
…te animation completion PP-1221
…Analysis screen completes via `performWhenAnimationCompleted` PP-1221
…1221-Implement-local-storage-for-the-client-configuration-flag-and-logic-to-display-the-message # Conflicts: # CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Analysis/AnalysisViewController.swift # CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Analysis/QREducation/QREducationLoadingController.swift
- improve the documentation PP-1221
mrkulik
approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ValentinaIancu-Gini thank you!
962e731
into
PP-1150-iOS-QR-code-User-FÜ-Education-concept
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement local storage for the client configuration flag and logic to display the message for the capturing invoice flow.