This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Merge in contract updates #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are currently cherry-picking commit a44a348.
Bw 446 add gas limit
10000
…e-safe-singleton-factory
Add new safe deployer address as 'n/a' to existing contract deploys. Add assert-browserify and resolution to webpack. Rename factory func to camelcase. Use sign with gas estimate over older sign.
Increase gas limit per bundle for BundleService submit test cases. Add event when simulating adding a bundle would exceeed max gas per bundle limit with details. Link emit func to AggregatationStrategy when created in test fixture.
* Audit issue 7 fixes * Remove unused params
461 audit fix 9
…o merge-in-contract-updates
Parallelize async calls in recoverWallet. Remove unneeded camelcase lint disables. Add comment for human reable times to expiry durations.
- use correct nonce in multiple operation sendTransaction error test - add Operation gas property to missing test setup - use new VG address
- set nonce to zero at all times in provider.estimateGas to prevent "BLSWallet: only callable with current nonce" error (see comment)
- update invalid transaction expected error message (due to using signWithGasEstimate in BlsSigner) - fix sign tx batch test by replicating what BlsSigner logic does cleanup - remove console logs - remove unnecessary transaction.to check
- sinon fake for getRandomBlsPrivateKey was resulting in throwawayBlsWalletWrapper nonce increasing when it should stay at zero - fake was using signers[0] private key - fix was to use fresh signer that wouldn't have its nonced changed in any other test
|
Tested in-quill transfers and billboard hiring ✅🚀 |
|
Tested ERC20 transfers ✅ |
|
Reviewed ✅ (Github won't let me use the review system because I opened the PR, but these aren't really my changes. The few changes from me were accepted by @jacque006 and I added a couple one-liners today but they're only in test code.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR integrates a significant number of contract related changes into main, including audit fixes, compression work, other contract related changes See merge commit messages for more details.
Diff & commits to review integration changes from contract-updates
How can these changes be manually tested?
Does this PR resolve or contribute to any issues?
No
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authorsTODO (in likely dep order