461 audit fix 9 #579
461 audit fix 9 #579
Conversation
contracts/test/recovery-test.ts
Outdated
| @@ -25,6 +29,7 @@ const signWalletAddress = async ( | |||
|
|
|||
| describe("Recovery", async function () { | |||
| const safetyDelaySeconds = 7 * 24 * 60 * 60; | |||
| const signatureExpiryWindow = 1200; | |||
There was a problem hiding this comment.
Chose this arbitrarily. Is equal to 100 12 second blocks.
Was a bit torn on whether this was a good variable name. Suggestions welcome :)
There was a problem hiding this comment.
It looks to be used as an offset, so signatureExpiryOffsetSeconds? (I like putting units in where meaningful)
There was a problem hiding this 8000 comment.
Like that - agree the units make sense here. Will update to signatureExpiryOffsetSeconds
|
CI seems to be failing due to some typescript issues in the client module. Doesn't seem related to this PR - got the same failures running clients tests in latest from |
contracts/test/recovery-test.ts
Outdated
| @@ -25,6 +29,7 @@ const signWalletAddress = async ( | |||
|
|
|||
| describe("Recovery", async function () { | |||
| const safetyDelaySeconds = 7 * 24 * 60 * 60; | |||
| const signatureExpiryWindow = 1200; | |||
There was a problem hiding this comment.
It looks to be used as an offset, so signatureExpiryOffsetSeconds? (I like putting units in where meaningful)
| 30_000_000, | ||
| ); | ||
|
|
||
| await fx.advanceTimeBy(safetyDelaySeconds + 1); |
There was a problem hiding this comment.
Minor: a couple of comments around the expiry timestamp, and expectations that the first set.. will succeed.
4e1151f to
4d20166
Compare
What is this PR doing?
Implements audit fix 9
How can these changes be manually tested?
Does this PR resolve or contribute to any issues?
contributes to #461
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors