Viper config implementation #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of uneeded DRY. Both commands share the same set of flags so consolidate into the root init. If individual flags are ever needed, we can set them in the init of each cmd. Signed-off-by: Luke Hinds <lhinds@redhat.com>
|
Note; this is based upon #272, so that will need landing first. Goddam DCO bot, I am positive I signed everything. |
|
6eb8a9b seems to be missing signature |
mihaimaruseac
requested changes
Dec 9, 2022
lumjjb
approved these changes
Dec 9, 2022
lumjjb
requested changes
Dec 9, 2022
This change allows three types of input (in order of load priority), in accordance with the 12 factor app design. * CLI flags * Environment Variables * Configuration file Environment variables are declared using the `GUAC` prefix, e.g.. `export GUAC_GDBUSER=neo4j` It requires the former creds value be split over two flags `--gdbuser neo4j --gdbpass password` Signed-off-by: Luke Hinds <lhinds@redhat.com>
730514a to
34c2859
Compare
|
give me a minute, i just started a git dumpster fire. |
Signed-off-by: Brandon Lum <lumjjb@gmail.com> Signed-off-by: Brandon Lum <lumjjb@gmail.com>
A bit of uneeded DRY. Both commands share the same set of flags so consolidate into the root init. If individual flags are ever needed, we can set them in the init of each cmd. Signed-off-by: Luke Hinds <lhinds@redhat.com> Signed-off-by: Luke Hinds <lhinds@redhat.com>
bc63bdb to
6db793b
Compare
Signed-off-by: Luke Hinds <lhinds@redhat.com>
|
should be good now |
added 3 commits
December 9, 2022 18:53
Signed-off-by: Luke Hinds <lhinds@redhat.com>
Signed-off-by: Luke Hinds <lhinds@redhat.com>
Signed-off-by: Luke Hinds <lhinds@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement viper for configuration mgmt
This change allows three types of input (in order of load priority), in accordance with the 12 factor app design.
Environment variables are declared using the
GUACprefix, e.g..export GUAC_GDBUSER=neo4jIt requires the former creds value be split over two flags:
--gdbuser neo4j --gdbpass passwordCloses: #273
Signed-off-by: Luke Hinds lhinds@redhat.com