Add Luke to TAM #271
Merged
Add Luke to TAM #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
pxp928
approved these changes
Dec 8, 2022
mihaimaruseac
approved these changes
Dec 8, 2022
lukehinds
pushed a commit
to lukehinds/guac
that referenced
this pull request
Dec 9, 2022
Signed-off-by: Brandon Lum <lumjjb@gmail.com> Signed-off-by: Brandon Lum <lumjjb@gmail.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
* Consolidate duplicate flag declarations A bit of uneeded DRY. Both commands share the same set of flags so consolidate into the root init. If individual flags are ever needed, we can set them in the init of each cmd. Signed-off-by: Luke Hinds <lhinds@redhat.com> * Implement viper for configuration mgmt This change allows three types of input (in order of load priority), in accordance with the 12 factor app design. * CLI flags * Environment Variables * Configuration file Environment variables are declared using the `GUAC` prefix, e.g.. `export GUAC_GDBUSER=neo4j` It requires the former creds value be split over two flags `--gdbuser neo4j --gdbpass password` Signed-off-by: Luke Hinds <lhinds@redhat.com> * Add Luke to TAM (#271) Signed-off-by: Brandon Lum <lumjjb@gmail.com> Signed-off-by: Brandon Lum <lumjjb@gmail.com> * Consolidate duplicate flag declarations A bit of uneeded DRY. Both commands share the same set of flags so consolidate into the root init. If individual flags are ever needed, we can set them in the init of each cmd. Signed-off-by: Luke Hinds <lhinds@redhat.com> Signed-off-by: Luke Hinds <lhinds@redhat.com> * Fix goimport lint complaints Signed-off-by: Luke Hinds <lhinds@redhat.com> * Handle err on viper.BindPflag Signed-off-by: Luke Hinds <lhinds@redhat.com> * Final lint fix Signed-off-by: Luke Hinds <lhinds@redhat.com> Signed-off-by: Luke Hinds <lhinds@redhat.com> Signed-off-by: Brandon Lum <lumjjb@gmail.com> Co-authored-by: Brandon Lum <lumjjb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @lukehinds to Technical Advisory Members!
Signed-off-by: Brandon Lum lumjjb@gmail.com