8000 Add HeadObjectRequest for HeadObjectRpc by brly · Pull Request #24 · frugalos/libfrugalos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add HeadObjectRequest for HeadObjectRpc #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2019
Merged

Add HeadObjectRequest for HeadObjectRpc #24

merged 3 commits into from
Oct 1, 2019

Conversation

brly
Copy link
Member
@brly brly commented Sep 27, 2019

概要

frugalos の HEAD リクエストでは mds までしか問い合わせが行われないが、storage 側にも存在確認を要求するための変更

変更点

  • struct HeadObjectRequest の追加
  • 既存の HeadObjectRpc の Req を ObjectRequest から HeadObjectRequest に変更

koba-e964
koba-e964 reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor
@koba-e964 koba-e964 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

src/schema/frugalos.rs Outdated
pub expect: Expect,
pub consistency: Option<ReadConsistency>,
/// ストレージ側にも問い合わせるかどうか
pub storage: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: check_storage みたいな名前にすると分かりやすくなりそうな気がします

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ですかね、変更します

shinnya
shinnya reviewed Sep 30, 2019
View reviewed changes
shinnya
shinnya reviewed Sep 30, 2019
View reviewed changes
src/client/frugalos.rs Outdated
bucket_id,
object_id,
deadline,
expect,
consistency: Some(consistency),
consistency: consistency,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
consistency: consistency,
consistency,

@brly brly force-pushed the feature/storage-head-request branch from 77c2a45 to d2ca87b Compare September 30, 2019 06:52
@brly brly mentioned this pull request Sep 30, 2019
Merged
4 tasks
@brly brly merged commit 7a62fb1 into frugalos:master Oct 1, 2019
@brly brly deleted the feature/storage-head-request branch October 1, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinnya shinnya shinnya approved these changes

@koba-e964 koba-e964 koba-e964 approved these changes

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brly @shinnya @koba-e964
0