Add storage-head feature #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brly
commented
Sep 30, 2019
brly
commented
Sep 30, 2019
e5a8bf2 to
22f6f51
Compare
22f6f51 to
1b3039c
Compare
koba-e964
reviewed
Oct 2, 2019
| @@ -69,6 +69,9 @@ impl ReplicatedClient { | |||
| }; | |||
| Box::new(future) | |||
| } | |||
| pub fn head(self, _version: ObjectVersion, _deadline: Deadline) -> BoxFuture<()> { | |||
There was a problem hiding this comment.
TODO コメントとかをつけていただけると助かります
There was a problem hiding this comment.
未実装の場合 unreachable!() を実装にしている既存コードがあります。が、これが普通なのかまでは分かっていません…。
There was a problem hiding this comment.
なるほど。
今回は未実装なんですけど、コードとしては到達してしまうのでマクロは置かないでおきますかね。
There was a problem hiding this comment.
ここは普通に到達する (Replicated バケツのオブジェクトに HEAD) ので、unreachable! にはしない方がいいのではという気がします。warn! とかはしてもいいかもという気がします。
There was a problem hiding this comment.
unreachable! を使ってるコードは本当に unreachable だったかもしれません。
brly
commented
Oct 3, 2019
| @@ -197,6 +206,10 @@ fn default_dispersed_client_get_timeout() -> Duration { | |||
| Duration::from_secs(2) | |||
| } | |||
|
|
|||
| fn default_dispersed_client_head_timeout() -> Duration { | |||
| Duration::from_secs(2) | |||
There was a problem hiding this comment.
デフォルトは既存の get_timeout に合わせていますが、短くても良い気もしています。
shinnya
reviewed
Oct 3, 2019
shinnya
reviewed
Oct 3, 2019
shinnya
approved these changes
Oct 3, 2019
koba-e964
approved these changes
Oct 3, 2019
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Please check one of the following:
masteranddevelop!)Description of changes
Behavior
オブジェクトへの HEAD リクエスト種別に storage (cannyls) にも存在確認を問い合わせられるようにする。
frugalos/libfrugalos#24 の PR の変更も必要。
Purpose
既存の HEAD リクエストでは mds までしか存在確認が行われなく、mds と cannyls で不整合が起きていた場合には既存の HEAD では判定出来ないため。
Checklists
cargo fmt --all.cargo clippy --all --all-targets.