falter-berlin-owmsh: Install cronjob #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
requested changes
Mar 20, 2025
packages/falter-common/Makefile
Outdated
There was a problem hiding this comment.
The new package needs to be added, otherwise it won't work.
Comment on lines
+36
to
+43
| define Package/falter-berlin-owmsh/postinst | ||
| #!/bin/sh | ||
| if [ -z $${IPKG_INSTROOT} ] ; then | ||
| ( . /etc/uci-defaults/owm ) && rm -f /etc/uci-defaults/owm | ||
| rm -f /tmp/luci-indexcache | ||
| fi | ||
| endef | ||
|
|
There was a problem hiding this comment.
I don't understand how this would install the cronjob. Can you please explain what it does?!?
There was a problem hiding this comment.
Thank you for the sharp review! You're right. I forgot to add the file, I'm sorry.
I've added the remaining thing in the updated version of this MR.
There was a problem hiding this comment.
do we really need to delete the luci-indexcache? from my understanding it is totally unrelated.
e99d8fa to
163dafa
Compare
Install cronjob for the owm.sh script. Follow up of 36f3535
163dafa to
2f2de3f
Compare
|
Pipeline fails due to reaching the unathed pull limit of the container registry. |
Noki
reviewed
Mar 21, 2025
| @@ -33,7 +33,7 @@ define Package/falter-common | |||
| TITLE:=Falter common files | |||
| EXTRA_DEPENDS:=uci, libuci-lua, lua, ip, ethtool, iwinfo, libiwinfo-lua, | |||
| EXTRA_DEPENDS+= uhttpd, uhttpd-mod-ubus, luci, luci-app-package-manager, luci-i18n-base-de, luci-i18n-package-manager-de, luci-proto-ppp, luci-theme-bootstrap, | |||
| EXTRA_DEPENDS+= luci-mod-falter, luci-i18n-falter-de, luci-app-falter-owm, luci-app-falter-owm-ant, luci-app-falter-owm-cmd, luci-app-falter-owm-gui, | |||
| EXTRA_DEPENDS+= luci-mod-falter, luci-i18n-falter-de, | |||
There was a problem hiding this comment.
still missing the new package as dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #473