Feature owm sh own package #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
requested changes
Mar 18, 2025
|
It might be a good idea to add this package without removing the old one for now. That way we can change the package and delete the old one once we confirm everything is working. |
We would like to use the owm publish script on notes with low flash too. As the former placement in the luci-package pulled a lot of luci dependencies on install, we move this into its own package.
7b78eb4 to
b3a3937
Compare
b3a3937 to
76eef5b
Compare
Sound good. I've created #474 for that and droped the respective commit here. Once rebased on main, that MR should contain only the commit in question. |
Noki
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kompiliert Ja/Nein: (Bitte gib Prozessorarchitektur, Modell und Falter/OpenWrtversion an)
Läuft live Ja/Nein: (Bitte gib Prozessorarchitektur, Modell und Falter/OpenWrtversion an und wie du deine Änderungen getestet hast)
Beschreibung deiner Änderungen:
Auf Nachfrage von @Noki ist das owm-script nun in einem eigenen Paket, das keine unnötigen luci-Dpenencies mehr braucht.