fix(mongodb): add all output types #696
Conversation
WalkthroughThe code updates references from Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
secator/hooks/mongodb.py (2)
81-81: Use isinstance for type checks instead of directtypecomparison.Comparing
type(item)against the list is brittle (fails for subclasses) and less idiomatic. Consider:-if type(item) not in OUTPUT_TYPES: - return item +if not isinstance(item, tuple(OUTPUT_TYPES)): + return item
123-123: Optimize name-based lookup with a dict for O(1) access.Iterating through
OUTPUT_TYPESeach call is O(n). You could build a lookup map once:# near imports _TYPE_MAP = {t.get_name(): t for t in OUTPUT_TYPES} def load_finding(obj): finding_type = obj['_type'] - for otype in OUTPUT_TYPES: + klass = _TYPE_MAP.get(finding_type) + if not klass: + return None + item = klass.load(obj) + item._uuid = str(obj['_id']) + return item return None
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
secator/hooks/mongodb.py(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: integration (3.11, ubuntu-latest)
- GitHub Check: Analyze (python)
🔇 Additional comments (1)
secator/hooks/mongodb.py (1)
9-9:✅ Verification successful
Confirm the existence and content of OUTPUT_TYPES.
The import replaces
FINDING_TYPESwithOUTPUT_TYPES; please verify thatOUTPUT_TYPESis defined insecator/output_types.pyand includes all the types needed byupdate_findingandload_finding.Run:
🏁 Script executed:
#!/bin/bash # Verify OUTPUT_TYPES definition rg -n "OUTPUT_TYPES" secator/output_types.pyLength of output: 108
🏁 Script executed:
#!/bin/bash # Locate any file named output_types.py in the repo fd output_types.py # Search for OUTPUT_TYPES definition or usage across all Python files rg -n "OUTPUT_TYPES" --glob "*.py"Length of output: 927
🏁 Script executed:
#!/bin/bash # Print initial part of OUTPUT_TYPES definition sed -n '1,200p' secator/output_types/__init__.py # Locate individual type groups rg -n "FINDING_TYPES" secator/output_types/__init__.py rg -n "EXECUTION_TYPES" secator/output_types/__init__.py rg -n "STAT_TYPES" secator/output_types/__init__.py # Show definitions of update_finding and load_finding rg -n -A5 "def update_finding" secator/hooks/mongodb.py rg -n -A5 "def load_finding" secator/hooks/mongodb.pyLength of output: 2379
OUTPUT_TYPES import is valid and complete
I’ve confirmed that in
secator/output_types/__init__.py:
FINDING_TYPES,EXECUTION_TYPES, andSTAT_TYPESare defined.OUTPUT_TYPES = FINDING_TYPES + EXECUTION_TYPES + STAT_TYPESincludes all classes referenced byupdate_findingandload_finding(Subdomain, Ip, Port, Url, Tag, Exploit, UserAccount, Vulnerability, Certificate, Target, Progress, Info, Warning, Error, State, Stat).No changes are required.
🤖 I have created a release *beep* *boop* --- ## [0.16.3](v0.16.2...v0.16.3) (2025-06-11) ### Bug Fixes * bup file flag ([#690](#690)) ([83d83d7](83d83d7)) * **celery:** add no_live_updates to skip backend updates ([#695](#695)) ([c99599c](c99599c)) * **dalfox:** use jsonl option instead of json ([#692](#692)) ([c406e34](c406e34)) * **mongodb:** add all output types ([#696](#696)) ([af98935](af98935)) * show info message for mark_runner_started / mark_runner_completed ([#694](#694)) ([ed0f6cb](ed0f6cb)) * **workflow:** put cariddi in crawlers group ([#693](#693)) ([a9e1afd](a9e1afd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary by CodeRabbit