8000 fix(dalfox): use jsonl option instead of json by ocervell · Pull Request #692 · freelabz/secator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(dalfox): use jsonl option instead of json #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix(dalfox): use jsonl option instead of json #692

merged 1 commit into from
Jun 10, 2025
+1 −6

Conversation

ocervell
Copy link
Contributor
@ocervell ocervell commented Jun 10, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Updated output format for dalfox tool to use JSONL.
    • Removed unused method related to line processing.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 10, 2025 •
edited
Loading

Walkthrough

The dalfox integration was updated to use the jsonl output format instead of json. Additionally, the static method on_line, which previously stripped trailing commas from lines, was removed from the codebase. No other logic or control flow was modified.

Changes

File(s) Change Summary
secator/tasks/dalfox.py Changed dalfox output format to jsonl; removed the static method on_line that stripped trailing commas.

Poem

A flag was flipped, from JSON to JSONL,
The rabbit hopped, and all was well.
No more commas to trim or chase,
The code is clean, a tidy place.
With every hop, the bugs grow thin—
Another change, another win!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83d83d7 and a206f65.

📒 Files selected for processing (1)
  • secator/tasks/dalfox.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: integration (3.11, ubuntu-latest)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
secator/tasks/dalfox.py (1)

30-30: Switch JSON flag to JSONL for newline-delimited output
Updating json_flag to --format jsonl correctly aligns with Dalfox’s JSONL mode. Please verify that downstream logic (e.g., JSONSerializer and any line-based parsing) properly handles each line as a standalone JSON object.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ocervell ocervell merged commit c406e34 into main Jun 10, 2025
10 checks passed
@ocervell ocervell mentioned this pull request Jun 10, 2025
Merged
ocervell added a commit that referenced this pull request Jun 11, 2025
@ocervell
chore(main): release 0.16.3 (#691)
a785306 
🤖 I have created a release *beep* *boop*
---


##
[0.16.3](v0.16.2...v0.16.3)
(2025-06-11)


### Bug Fixes

* bup file flag ([#690](#690))
([83d83d7](83d83d7))
* **celery:** add no_live_updates to skip backend updates
([#695](#695))
([c99599c](c99599c))
* **dalfox:** use jsonl option instead of json
([#692](#692))
([c406e34](c406e34))
* **mongodb:** add all output types
([#696](#696))
([af98935](af98935))
* show info message for mark_runner_started / mark_runner_completed
([#694](#694))
([ed0f6cb](ed0f6cb))
* **workflow:** put cariddi in crawlers group
([#693](#693))
([a9e1afd](a9e1afd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ocervell
0