8000 perf: skip ifnull checks on `modified` field (backport #24042) by mergify[bot] · Pull Request #24813 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf: skip ifnull checks on modified field (backport #24042) #24813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Feb 8, 2024

This is an automatic backport of pull request #24042 done by Mergify.
Cherry-pick of 64c2213 has failed:

On branch mergify/bp/version-14-hotfix/pr-24042
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 64c221343e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/model/db_query.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 64c2213)

# Conflicts:
#	frappe/model/db_query.py
@mergify mergify bot requested a review from a team February 8, 2024 14:51
@mergify mergify bot added the conflicts label Feb 8, 2024
@mergify mergify bot requested review from akhilnarang and removed request for a team February 8, 2024 14:51
@mergify mergify bot assigned ankush Feb 8, 2024
@ankush ankush enabled auto-merge (squash) February 9, 2024 06:01
@ankush ankush added Skip CI Doesn't run Ci for this PR. and removed conflicts labels Feb 9, 2024
@ankush ankush merged commit 56a9579 into version-14-hotfix Feb 9, 2024
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-24042 branch February 9, 2024 06:02
ankush added a commit that referenced this pull request Feb 9, 2024
(cherry picked from commit 64c2213)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Feb 14, 2024
# [14.66.0](v14.65.0...v14.66.0) (2024-02-14)

### Bug Fixes

* Abort flushing email queue if >50% fail. ([c825035](c825035))
* add default timezone for Tanzania ([c1599f3](c1599f3))
* Added Mongolian language ([#24803](#24803)) ([#24848](#24848)) ([7e02dd8](7e02dd8))
* Avoid sending password back ([#24794](#24794)) ([#24795](#24795)) ([3335bf3](3335bf3))
* check param type in mark_as_seen(note) ([52ebde3](52ebde3))
* console import progress off-by-one ([#24777](#24777)) ([#24786](#24786)) ([12234ab](12234ab))
* **DX:** show user who modified in diff view ([#24790](#24790)) ([#24791](#24791)) ([3859f42](3859f42))
* flush emails from single background jobs ([e833346](e833346))
* Ignore "Invalid Doctype" validation if ignore flag is passed (backport [#24818](#24818)) ([#24821](#24821)) ([87c2600](87c2600))
* **login:** Escape translated strings (backport [#24431](#24431)) ([#24700](#24700)) ([9f4b39c](9f4b39c))
* preferred_language cookie ([#24819](#24819)) ([#24826](#24826)) ([6369301](6369301))
* remove _ from frappe.model.std_fields (Backport [#24662](#24662)) ([#24881](#24881)) ([0c74d2f](0c74d2f))

### Features

* add style & onEachFeature function for geojson in geolocation controller ([#21322](#21322)) ([8e9b4be](8e9b4be))
* frapp.model.can_submit (JS) ([2a28d04](2a28d04))
* Jinja syntax highlighting (backport [#23760](#23760)) ([#24834](#24834)) ([fbf7b1c](fbf7b1c))

### Performance Improvements

* faster workflow action processing (backport [#24862](#24862)) ([#24865](#24865)) ([e01c11d](e01c11d))
* skip ifnull checks on `modified` field ([#24042](#24042)) ([#24813](#24813)) ([56a9579](56a9579))
* use unique file url ([#24830](#24830)) ([#24835](#24835)) ([34e2022](34e2022))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.66.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Skip CI Doesn't run Ci for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0