8000 feat: Jinja syntax highlighting by barredterra · Pull Request #23760 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Jinja syntax highlighting #23760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Conversation

barredterra
Copy link
Collaborator
@barredterra barredterra commented Dec 12, 2023
  • Add Jinja syntax highlighting to ACE editor

    ACE doesn't explicitly support Jinja, but "Django" which has a very similar syntax.

  • Switch from pure HTML to Jinja highlighting in the following DocTypes:

    • Email Template
    • Print Format
    • Web Template

Preview

Bildschirmfoto 2023-12-12 um 20 11 56

no-docs

@barredterra barredterra requested review from a team and ankush and removed request for a team December 12, 2023 19:09
Copy link
codecov bot commented Dec 17, 2023

Codecov Report

Merging #23760 (70c7315) into develop (3adc83e) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23760      +/-   ##
===========================================
- Coverage    62.26%   62.24%   -0.02%     
===========================================
  Files          774      774              
  Lines        74110    74110              
  Branches      6371     6371              
===========================================
- Hits         46142    46133       -9     
- Misses       24337    24346       +9     
  Partials      3631     3631              
Flag Coverage Δ
server 71.11% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit 4c55117 into frappe:develop Dec 18, 2023
@barredterra barredterra deleted the jinja-syntax branch December 18, 2023 09:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
@ankush ankush added backport version-15-hotfix Backport the PR to v15 backport version-14-hotfix backport to version 14 labels Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0