fix: don't allow setting an invalid rating #22633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #22633 +/- ##
===========================================
- Coverage 62.34% 62.34% -0.01%
===========================================
Files 768 768
Lines 73515 73519 +4
Branches 6332 6332
===========================================
+ Hits 45834 45836 +2
- Misses 24102 24104 +2
Partials 3579 3579
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
reviewed
Oct 10, 2023
|
@akhilnarang add one test case covering all 3 cases. Rest lgtm. |
111a80f to
d6e64e3
Compare
ankush
reviewed
Oct 10, 2023
frappe/model/base_document.py
Outdated
| @@ -371,6 +371,13 @@ def get_valid_dict( | |||
| elif df.fieldtype in float_like_fields and not isinstance(value, float): | |||
| value = flt(value) | |||
|
|
|||
| elif df.fieldtype == "Rating": | |||
There was a problem hiding this comment.
It's best to move this to document's _validate method. get_valid_dict is serializer function, so it shouldn't be applying business logic here.
Convert anything <0 to 0, and anything >1 to 1 Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
d6e64e3 to
4c93e60
Compare
ankush
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert anything <0 to 0, and anything >1 to 1
Resolves #16245
Before this patch:
After this patch: