8000 limit rating field type values to max 1 · Issue #16245 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
limit rating field type values to max 1 #16245
Closed
@ankush

Description

@ankush

Rating field stores a floating point value between 0-1, this is required to allow converting number of stars without patching data.

However, you can end up writing some buggy code that stores value more than 1.0, this should be prevented by server-side validation.

Currently no validation on:

  1. API
  2. Frontend (client script can modify it)

Implementation:

  • base_document.py contains many fieldtype specific validations, add a new one there for rating fieldtype.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0