fix(security): prevent xss attack in the search field #18847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18847 +/- ##
===========================================
- Coverage 63.58% 63.53% -0.06%
===========================================
Files 749 749
Lines 67443 67440 -3
Branches 6012 6012
===========================================
- Hits 42886 42845 -41
- Misses 21140 21170 +30
- Partials 3417 3425 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
approved these changes
Nov 11, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
(cherry picked from commit bfab719)
ankush
pushed a commit
that referenced
this pull request
Nov 11, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
(cherry picked from commit bfab719)
ankush
pushed a commit
that referenced
this pull request
Nov 11, 2022
|
Would it be possible to get a backport to 12 too? |
|
@Mutantpenguin version-12 is not supported anymore. Please upgrade to v13 for security/bug fixes. This one's small change so can be ported easily. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2022
(cherry picked from commit bfab719)
ankush
pushed a commit
that referenced
this pull request
Nov 12, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
# [14.15.0](v14.14.3...v14.15.0) (2022-11-15) ### Bug Fixes * avoid patching QB if already patched ([a8ba877](a8ba877)) * breadcrumbs is broken ([90ca7b1](90ca7b1)) * check if the doctype exists before adding default logtypes in log settings ([#18867](#18867)) ([#18869](#18869)) ([93fe3e9](93fe3e9)) * dashboard view from workspace (backport [#18779](#18779)) ([#18813](#18813)) ([42f5e04](42f5e04)) * decorator ordering ([2245cc0](2245cc0)) * dont allow reading attributes of unsafe objects (backport [#18706](#18706)) ([#18806](#18806)) ([2b193bd](2b193bd)), closes [#18784](#18784) * hardcode doctype in google oauth callback ([#18862](#18862)) ([78a337b](78a337b)) * page has an empty menu button ([b2bbcde](b2bbcde)) * raise exception if doc before save is not found ([#18796](#18796)) ([#18820](#18820)) ([7505a0d](7505a0d)) * reportview permlevel bug ([#18822](#18822)) ([#18828](#18828)) ([ec248a9](ec248a9)) * **security:** prevent xss attack in search ([#18847](#18847)) ([#18850](#18850)) ([8807035](8807035)) ### Features * Set default SQL statement timeouts ([8ab95f4](8ab95f4)) * show utilization percent on RQ Worker ([#18868](#18868)) ([#18870](#18870)) ([a7060fa](a7060fa)) ### Performance Improvements * faster as_list and as_dict ([33d6369](33d6369)) * faster generate_hash (backport [#18825](#18825)) ([#18851](#18851)) ([bb5c7d5](bb5c7d5)) * **workflow:** get_transitions ([#18834](#18834)) ([#18839](#18839)) ([3f71181](3f71181)) ### Reverts * async await in breadcrumbs.js ([6a1e619](6a1e619))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
# [13.44.0](v13.43.2...v13.44.0) (2022-11-15) ### Bug Fixes * page has an empty menu button ([637cb45](637cb45)) * reportview permlevel bug (backport [#18822](#18822)) ([#18827](#18827)) ([acb6f57](acb6f57)) * reset workspace ([271c5d0](271c5d0)) * **security:** prevent xss attack in search ([#18847](#18847)) ([#18849](#18849)) ([8b42091](8b42091)) ### Features * Set default SQL statement timeouts (backport [#18771](#18771)) ([#18800](#18800)) ([127763a](127763a)) ### Performance Improvements * **workflow:** get_transitions ([#18834](#18834)) ([9ec557d](9ec557d))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
30E6
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
navbar_searchcheckbox of the Website Settings is checked an attack is possible where the attacker sends the victim a link. If the victim clicks on the link, some JavaScript code can be executed.