feat: Set default SQL statement timeouts #18771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18771 +/- ##
===========================================
+ Coverage 63.53% 63.62% +0.08%
===========================================
Files 748 748
Lines 67375 67900 +525
Branches 6011 6011
===========================================
+ Hits 42810 43202 +392
- Misses 21148 21286 +138
+ Partials 3417 3412 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Nov 8, 2022
ankush
added a commit
that referenced
this pull request
Nov 8, 2022
…-18771 feat: Set default SQL statement timeouts (backport #18771)
ankush
added a commit
that referenced
this pull request
Nov 8, 2022
ankush
added a commit
that referenced
this pull request
Nov 9, 2022
ankush
added a commit
that referenced
this pull request
Nov 9, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
# [13.44.0](v13.43.2...v13.44.0) (2022-11-15) ### Bug Fixes * page has an empty menu button ([637cb45](637cb45)) * reportview permlevel bug (backport [#18822](#18822)) ([#18827](#18827)) ([acb6f57](acb6f57)) * reset workspace ([271c5d0](271c5d0)) * **security:** prevent xss attack in search ([#18847](#18847)) ([#18849](#18849)) ([8b42091](8b42091)) ### Features * Set default SQL statement timeouts (backport [#18771](#18771)) ([#18800](#18800)) ([127763a](127763a)) ### Performance Improvements * **workflow:** get_transitions ([#18834](#18834)) ([9ec557d](9ec557d))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "SOME" cases queries keep running even after client has disconnected or died.
If you have sent some crazy queries they can keep running for long time and wreak havoc.
This is a MySQL bug, which will likely never get fixed because as per mysql devs:
Reference: https://bugs.mysql.com/bug.php?id=78809
WARNING: Experimental and internal to framework, might get removed! 🤷
To enable set
enable_db_statement_timeto 1 in site or common config.TODO:
Alternative: Suggest setting these globally in config files (?)
closes #18768
no-docs- not user facing.