fix: send all messages on boot instead of scanning #18764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f70ea5b to
533f092
Compare
|
I played around for an hour and didn't find any unintended consequences of 2bc8c26. |
|
Failing checks unrelated, fixed in #18761 |
|
@barredterra please raise frontports first for any fixes, easy to miss them out 😐 |
|
Done, @ankush |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
## [13.43.2](v13.43.1...v13.43.2) (2022-11-08) ### Bug Fixes * don't translate default argument ([#18760](#18760)) ([8038ed7](8038ed7)) * module 'frappe' has no attribute 'build' ([#18761](#18761)) ([a867d56](a867d56)) * not able to click checkbox in file grid view ([ad85843](ad85843)) * send all messages on boot instead of scanning ([#18764](#18764)) ([640724d](640724d)) * show 0 for empty currency, float, & duration fields in list view ([2290fb8](2290fb8)) * translations (backport [#18765](#18765)) ([#18781](#18781)) ([ca631ba](ca631ba)) ### Performance Improvements * ensure cache works for `non_standard_user_types` when empty ([#18744](#18744)) ([708ee35](708ee35)) ### Reverts * Revert "refactor: accurate translation caching (backport #18595) (#18598)" (#18741) ([e4d12f0](e4d12f0)), closes [#18595](#18595) [#18598](#18598) [#18741](#18741)
|
🎉 This PR is included in version 13.43.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ec8f20c from feat: use babel to extract translation sources #17697
Remove redundant translation
As all translations are now loaded on boot, additionally loading specific translations does not make sense any more.
Todo: