refactor: accurate translation caching (backport #18595) #18598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## version-13-hotfix #18598 +/- ##
=====================================================
+ Coverage 62.88% 63.09% +0.20%
=====================================================
Files 755 747 -8
Lines 67911 67256 -655
Branches 5987 5996 +9
=====================================================
- Hits 42705 42434 -271
+ Misses 21779 21360 -419
- Partials 3427 3462 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
* refactor: rename poorly named functions * refactor: getting translation from apps - use generator - use sane name for cache key - avoid manual handling of frappe.local state just use cache() interface (cherry picked from commit 3ddac5f) # Conflicts: # frappe/__init__.py # frappe/core/doctype/translation/test_translation.py # frappe/tests/utils.py # frappe/translate.py
5e31bb5 to
a128d22
Compare
|
🎉 This PR is included in version 13.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ankush
added a commit
that referenced
this pull request
Nov 3, 2022
ankush
added a commit
that referenced
this pull request
Nov 3, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
## [13.43.2](v13.43.1...v13.43.2) (2022-11-08) ### Bug Fixes * don't translate default argument ([#18760](#18760)) ([8038ed7](8038ed7)) * module 'frappe' has no attribute 'build' ([#18761](#18761)) ([a867d56](a867d56)) * not able to click checkbox in file grid view ([ad85843](ad85843)) * send all messages on boot instead of scanning ([#18764](#18764)) ([640724d](640724d)) * show 0 for empty currency, float, & duration fields in list view ([2290fb8](2290fb8)) * translations (backport [#18765](#18765)) ([#18781](#18781)) ([ca631ba](ca631ba)) ### Performance Improvements * ensure cache works for `non_standard_user_types` when empty ([#18744](#18744)) ([708ee35](708ee35)) ### Reverts * Revert "refactor: accurate translation caching (backport #18595) (#18598)" (#18741) ([e4d12f0](e4d12f0)), closes [#18595](#18595) [#18598](#18598) [#18741](#18741)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18595 done by Mergify.
Cherry-pick of 3ddac5f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com