fix: no role assigned message when role profile is passed (backport #21342) #21352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: no role assigned message when role profile is passed * refactor: rename misleading method --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 9d20509)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
# [14.39.0](v14.38.3...v14.39.0) (2023-06-13) ### Bug Fixes * allow video files to be uploaded ([9c43e40](9c43e40)) * Clear hash once the scrolling is done ([c89a390](c89a390)) * consider default value for content in update_workspace2 patch ([#21258](#21258)) ([#21286](#21286)) ([fa7c114](fa7c114)) * currency precision formatter ([#21293](#21293)) ([#21295](#21295)) ([c5fa12d](c5fa12d)) * error in workspace patch ([#21335](#21335)) ([b452c63](b452c63)) * handle fixture syncing for missing doctypes ([cad99f1](cad99f1)) * improve delete_contact_and_address ([#20381](#20381)) ([#21280](#21280)) ([fcb614e](fcb614e)) * New Dashboard Chart throws TypeError: format requires a mapping (backport [#21275](#21275)) ([#21299](#21299)) ([0a5bec5](0a5bec5)), closes [#21250](#21250) * no role assigned message when role profile is passed ([#21342](#21342)) ([#21352](#21352)) ([e23503b](e23503b)) * Pass URL hash separately ([ef47548](ef47548)) * reuse redis connection if not rq auth ([#21336](#21336)) ([2748d9c](2748d9c)) * skip custom script syncing for missing doctypes ([12b8dac](12b8dac)) * sync importable doctype before documents ([#21131](#21131)) ([#21327](#21327)) ([0852b37](0852b37)) * virtual fields in child tables not displaying ([#20528](#20528)) ([#21329](#21329)) ([232f217](232f217)) ### Features * Scroll to field via URL ([604c4a3](604c4a3)) ### Performance Improvements * use cached workflow doc for transitions (backport [#21300](#21300)) ([#21301](#21301)) ([b6fb8a2](b6fb8a2))
|
🎉 This PR is included in version 14.39.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #21342 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com