8000 fix: virtual fields in child tables not displaying by vvrithof · Pull Request #20528 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: virtual fields in child tables not displaying #20528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 6, 2023
Merged

fix: virtual fields in child tables not displaying #20528

merged 7 commits into from
Apr 6, 2023

Conversation

vvrithof
Copy link
Contributor
@vvrithof vvrithof commented Mar 30, 2023 •
edited
Loading

fixes #20526

backport version-14-hotfix

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Mar 30, 2023
@vvrithof vvrithof marked this pull request as ready for review March 30, 2023 13:55
@vvrithof vvrithof requested review from a team and phot0n and removed request for a team March 30, 2023 13:55
ankush
ankush requested changes Mar 31, 2023
View reviewed changes
@vvrithof @ankush
Update frappe/model/base_document.py
891fda5 
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
@ankush ankush added the squash label Mar 31, 2023
@codecov
Copy link
codecov bot commented Mar 31, 2023 •
edited
Loading

Codecov Report

Merging #20528 (891fda5) into develop (32724a8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 891fda5 differs from pull request most recent head 8f5ef4c. Consider uploading reports for the commit 8f5ef4c to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #20528      +/-   ##
===========================================
+ Coverage    63.75%   63.80%   +0.04%     
===========================================
  Files          758      758              
  Lines        68703    68677      -26     
  Branches      6196     6194       -2     
===========================================
+ Hits         43804    43820      +16     
- Misses       21262    21319      +57     
+ Partials      3637     3538      -99
Flag Coverage Δ
server 68.77% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush self-assigned this Mar 31, 2023
@vvrithof vvrithof requested a review from ankush April 4, 2023 12:49
@vvrithof
Copy link
Contributor Author
vvrithof commented Apr 4, 2023

@ankush I'm sorry, this is my very first PR. Do I need to do something or just wait for your review ?

@ankush
Copy link
Member
ankush commented Apr 6, 2023

@vvrithof nothing much left from your side, I just haven't got time to deeply review if there are any side effects of this. On surface it seems fine 😅

@ankush ankush merged commit 090c91b into frappe:develop Apr 6, 2023
@ankush ankush added defer backport Backports for some PR are deferred for a week or two to test them properly before releasing and removed add-test-cases Add test case to validate fix or enhancement backport version-13-hotfix backport version-14-hotfix backport to version 14 labels Apr 6, 2023
@vvrithof vvrithof deleted the fix--virtual-fields-in-child-tables branch April 6, 2023 07:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
@ankush ankush added backport version-13-hotfix and removed defer backport Backports for some PR are deferred for a week or two to test them properly before releasing labels Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phot0n phot0n Awaiting requested review from phot0n

@ankush ankush Awaiting requested review from ankush

Assignees

@ankush ankush

Labels
backport version-14-hotfix backport to version 14 squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual fields display broken in child tables
2 participants
@vvrithof @ankush
0