-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: improve delete_contact_and_address #20381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve delete_contact_and_address #20381
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #20381 +/- ##
===========================================
+ Coverage 63.73% 64.14% +0.41%
===========================================
Files 758 758
Lines 68872 70120 +1248
Branches 6199 6190 -9
===========================================
+ Hits 43893 44976 +1083
- Misses 21435 21613 +178
+ Partials 3544 3531 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
frappe.get_all
instead offrappe.db.sql_list
Docs: https://docs.erpnext.com/docs/v14/user/manual/en/CRM/customer/edit-wiki?wiki_page_patch=6cf3b35ab1, https://docs.erpnext.com/docs/v14/user/manual/en/buying/supplier/edit-wiki?wiki_page_patch=eb285d7ff7