8000 fix: improve delete_contact_and_address by barredterra · Pull Request #20381 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: improve delete_contact_and_address #20381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

barredterra
Copy link
Collaborator
@barredterra barredterra commented Mar 17, 2023
  • Use frappe.get_all instead of frappe.db.sql_list
  • If Address/Contact is linked to more than one entity, remove the link to the deleted entity (instead of not doing anything, which would result in a LinkExistsError).

Docs: https://docs.erpnext.com/docs/v14/user/manual/en/CRM/customer/edit-wiki?wiki_page_patch=6cf3b35ab1, https://docs.erpnext.com/docs/v14/user/manual/en/buying/supplier/edit-wiki?wiki_page_patch=eb285d7ff7

@barredterra barredterra requested review from a team and shariquerik and removed request for a team March 17, 2023 16:30
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Mar 17, 2023
@stale
Copy link
stale bot commented Mar 24, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Mar 24, 2023
@stale
Copy link
stale bot commented Apr 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Apr 1, 2023
@codecov
Copy link
codecov bot commented Apr 3, 2023

Codecov Report

Merging #20381 (556e61f) into develop (b898029) will increase coverage by 0.41%.
The diff coverage is 14.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20381      +/-   ##
===========================================
+ Coverage    63.73%   64.14%   +0.41%     
===========================================
  Files          758      758              
  Lines        68872    70120    +1248     
  Branches      6199     6190       -9     
===========================================
+ Hits         43893    44976    +1083     
- Misses       21435    21613     +178     
+ Partials      3544     3531      -13     
Flag Coverage Δ
server 69.22% <14.28%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@stale
Copy link
stale bot commented Apr 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Apr 10, 2023
@stale stale b 8000 ot closed this Apr 17, 2023
@barredterra barredterra reopened this Apr 18, 2023
@stale stale bot removed the inactive label Apr 18, 2023
@surajshetty3416 surajshetty3416 changed the title feat: improve delete_contact_and_address fix: improve delete_contact_and_address Apr 24, 2023
@surajshetty3416 surajshetty3416 merged commit fc10325 into frappe:develop Apr 24, 2023
@barredterra barredterra deleted the delete_contact_and_address branch April 24, 2023 13:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
@barredterra barredterra added the backport version-14-hotfix backport to version 14 label Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0