Fix NameError #28
Merged
Fix NameError #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #24. |
|
@PrabhanshuAttri I have changed the test definition to assert equality with the expected value itself. Is this okay? |
|
@schedutron There is something wrong here. It shows all the changes I have made and your changes as well. This can mess up the git history. Can you please create a PR with just your changes? |
|
@schedutron Could you please take pull from dev and fix these issues? |
|
@PrabhanshuAttri Everything all right now? |
|
I think so. What was the problem? |
|
@PrabhanshuAttri You asked to pull from dev and fix the history issues. |
|
Good work. Will merge it soon. |
|
@PrabhanshuAttri Thanks :) |
|
Could you please set ret on line 62 instead of directly asserting it in line 63? |
|
@PrabhanshuAttri Done. |
PrabhanshuAttri
added a commit
that referenced
this pull request
Oct 4, 2017
PrabhanshuAttri
added a commit
that referenced
this pull request
Oct 4, 2017
PrabhanshuAttri<
8000
/a>
added a commit
that referenced
this pull request
Oct 5, 2017
* version 0.2.7 dev * .gitignore added (#19) * Fix NameError (#28) * Fix NameError * Fix test definition testEncodeUidSuccess * Assign ret * Version 0.2.8 (#32) * added pypi distribution dir * updated to 0.2.8 * removed irregularities in License * Add badges (#34) * [NEW] Add LICENSE badge * [NEW] Add pypi package version badge
PrabhanshuAttri
pushed a commit
that referenced
this pull request
Oct 6, 2017
* Merging dev: added badges (#35) * version 0.2.7 dev * .gitignore added (#19) * Fix NameError (#28) * Fix NameError * Fix test definition testEncodeUidSuccess * Assign ret * Version 0.2.8 (#32) * added pypi distribution dir * updated to 0.2.8 * removed irregularities in License * Add badges (#34) * [NEW] Add LICENSE badge * [NEW] Add pypi package version badge * Moving PyPi badge after Travis badge
PrabhanshuAttri
added a commit
that referenced
this pull request
Oct 6, 2017
* version 0.2.7 dev * .gitignore added (#19) * Fix NameError (#28) * Fix NameError * Fix test definition testEncodeUidSuccess * Assign ret * Version 0.2.8 (#32) * added pypi distribution dir * updated to 0.2.8 * removed irregularities in License * Add badges (#34) * [NEW] Add LICENSE badge * [NEW] Add pypi package version badge * Moving PyPi badge after Travis badge (#38) * Merging dev: added badges (#35) * version 0.2.7 dev * .gitignore added (#19) * Fix NameError (#28) * Fix NameError * Fix test definition testEncodeUidSuccess * Assign ret * Version 0.2.8 (#32) * added pypi distribution dir * updated to 0.2.8 * removed irregularities in License * Add badges (#34) * [NEW] Add LICENSE badge * [NEW] Add pypi package version badge * Moving PyPi badge after Travis badge * [NEW] Add 'CONTRIBUTING.md' file (#45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.