8000 Fix NameError in test_pybeacon.py · Issue #24 · forksociety/PyBeacon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix NameError in test_pybeacon.py #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms 8000 of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PrabhanshuAttri opened this issue Oct 4, 2017 · 10 comments
Closed

Fix NameError in test_pybeacon.py #24

PrabhanshuAttri opened this issue Oct 4, 2017 · 10 comments
Labels
bug Hacktoberfest help wanted LightyBroiled

Comments

@PrabhanshuAttri
Copy link
Collaborator

This error is thrown while testing PyBeacon methods.
NameError: global name 'encodeUid' is not defined
@schedutron
Copy link
Collaborator

Let me do this.

@PrabhanshuAttri
Copy link
Collaborator Author

Go head. Create a PR when it's done.

@schedutron
Copy link
Collaborator

@PrabhanshuAttri How do I build this locally? Are there some special techniques required apart from just cloning?

@PrabhanshuAttri
Copy link
Collaborator Author
  • Clone the repo
  • Install the test dependencies (use sudo if you face issue)
pip install coveralls pytest pytest-cov
  • run the following command to test
py.test

Tests/test_pybeacon contains 2 methods in the end which are commented. You will have to fix these methods

@schedutron schedutron mentioned this issue Oct 4, 2017
Closed
@schedutron
Copy link
Collaborator

Why are CI checks failing?

@PrabhanshuAttri
Copy link
Collaborator Author
PrabhanshuAttri commented Oct 4, 2017 •
edited
Loading

Assert is comparing an empty array with a valid array.

@schedutron
Copy link
Collaborator

@PrabhanshuAttri Is it a problem with test definitions, or any of the lines I've added?

@PrabhanshuAttri
Copy link
Collaborator Author

Test definitions. Let me know if you can fix them. Also, please create the PR against dev branch.

@PrabhanshuAttri
Copy link
Collaborator Author

@schedutron Let me know if you need help.

@schedutron
Copy link
Collaborator

@PrabhanshuAttri I've added PR #28 against the dev branch now.

@schedutron schedutron mentioned this issue Oct 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Hacktoberfest help wanted LightyBroiled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PrabhanshuAttri @schedutron
0