8000 FIO-10111: fixed na issue where layout components are wrongly considered to have the same path and show the repeated key validation error by TanyaGashtold · Pull Request #6125 · formio/formio.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIO-10111: fixed na issue where layout components are wrongly considered to have the same path and show the repeated key validation error #6125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

FIO-10111: fixed na issue where layout components are wrongly considered to have the same path and show the repeated key validation error #6125

wants to merge 4 commits into from

Conversation

TanyaGashtold
Copy link
Contributor
@TanyaGashtold TanyaGashtold commented May 20, 2025 •
edited
Loading

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10111

Description

What changed?

When the findRepeatablePaths it relies on the dataPath, but the layout components inside data components have the same data path as the parent data component that causes the validation errors for layout components in builder. This PR fixes this issue.

Removed the test that passed in the code and did not work in reality in builder UI (seems like almost never).

Dependencies

formio/core#255
formio/formio#1982
https://github.com/formio/formio-app/pull/1698

automated test added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

This was referenced May 22, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TanyaGashtold
0