8000 FIO-10111: fixed an issue where getComponent returns wrong data component when this data component has layout components inside by TanyaGashtold · Pull Request #255 · formio/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIO-10111: fixed an issue where getComponent returns wrong data component when this data component has layout components inside #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2025
Merged

FIO-10111: fixed an issue where getComponent returns wrong data component when this data component has layout components inside #255

merged 3 commits into from
Jun 5, 2025

Conversation

TanyaGashtold
Copy link
Contributor
@TanyaGashtold TanyaGashtold commented May 20, 2025 •
edited
Loading

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10111

Description

What changed?

This PR:

  • fixed model type for tab components inside tabs. So, the tabs components have child components that represent each tab. Each tab component does not have any properties inside except key, title and its own array of components. Obviously that each tab is a layout component and its correct modelType is 'none'. But the 'getModelType' defines it as 'any' that creates issues with in getComponent.
  • fixed the check inside componentMatches that previously allowed layout components when their dataIndex is undefined.
  • changed the componentInfo so that it does not consider the tab components (that are inside tabs) as input component. This is required for my changes in formio and formio.js

Dependencies

formio/formio#1982
https://github.com/formio/formio-app/pull/1698
formio/formio.js#6125

How has this PR been tested?

tests + manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

This was referenced May 20, 2025
Merged
Merged
@brendanbond brendanbond merged commit 1950837 into master Jun 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanbond brendanbond brendanbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanyaGashtold @brendanbond
0