FontBuilder improvements #1357
Merged
FontBuilder improvements #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- some doc strings
- new setupHorizontalMetrics and setupVerticalMetrics methods
- test for variations (but: the variation support is very minimal and low level, I need to figure out how varLib could be involved here)
anthrotype
reviewed
Nov 2, 2018
|
|
||
| f = TTFont(outPath) | ||
| f.saveXML(outPath + ".ttx") | ||
| f.saveXML('test_var.ttf.ttx') # XXXX |
There was a problem hiding this comment.
is this saved in the current directory? tmpdir would be better
There was a problem hiding this comment.
Oops, that line shouldn't have been there. Fixed in master.
anthrotype
reviewed
Nov 2, 2018
| TupleVariation(dict(UPPP=(0, 1, 1)), upDeltas), | ||
| TupleVariation(dict(DOWN=(0, 1, 1)), downDeltas), | ||
| ] | ||
| fb.setupGvar(variations) |
justvanrossum
added a commit
to justvanrossum/fonttools
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.