8000 [name] make addMultilingualNames() add mac names by default by justvanrossum · Pull Request #1359 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[name] make addMultilingualNames() add mac names by default #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 7, 2019
Merged

[name] make addMultilingualNames() add mac names by default #1359

merged 4 commits into from
Jan 7, 2019

Conversation

justvanrossum
Copy link
Collaborator

As discussed in #930.

anthrotype
anthrotype reviewed Nov 2, 2018
View reviewed changes
Lib/fontTools/ttLib/tables/_n_a_m_e.py
# We cannot not make a Windows name: make sure we add a
# Mac name as a fallback. This can happen for exotic
# BCP47 language tags that have no Windows language code.
mac = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if there is neither windows nor mac compatible name? shouldn't we error, or return None or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. In the previous revision this situation passed silently also. Leaning towards an error.

@justvanrossum
Copy link
8000 Collaborator Author

Hm, not sure why the tests are failing, maybe I messed something up locally when merging #1357

@anthrotype
Copy link
Member

@justvanrossum what's the status of this? Can it be merged?

this TODO in varLib may be related:

fonttools/Lib/fontTools/varLib/__init__.py

Lines 78 to 83 in 1fd9bf6

axis.axisNameID = nameTable.addName(tounicode(a.labelNames['en']))
# TODO:
# Replace previous line with the following when the following issues are resolved:
# https://github.com/fonttools/fonttools/issues/930
# https://github.com/fonttools/fonttools/issues/931
# axis.axisNameID = nameTable.addMultilingualName(a.labelname, font)

@justvanrossum
Copy link
Collaborator Author

Can be merged as far as I'm concerned, thanks!

@anthrotype anthrotype merged commit 683547d into fonttools:master Jan 7, 2019
anthrotype added a commit that referenced this pull request Jan 7, 2019
@anthrotype
fontBuilder_test: Fix up expected test data for test_var.otf.ttx
dc46008 
after merging #1359
anthrotype added a commit that referenced this pull request Jan 7, 2019
@anthrotype
fontBuilder: add options to setupNameTable to disable Mac (or Win) names
68e918d 
as of #1359, both sets of names are added by
default. This allows users to optionally exclude Macintosh platform names (i.e. mac=False).
This was referenced Jan 7, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justvanrossum @anthrotype
0