8000 [varLib] use designspaceLib, and depreacate varLib.designspace module by anthrotype · Pull Request #1313 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[varLib] use designspaceLib, and depreacate varLib.designspace module #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 12, 2018
Merged

[varLib] use designspaceLib, and depreacate varLib.designspace module #1313

merged 12 commits into from
Sep 12, 2018

Conversation

anthrotype
Copy link
Member

fixes #1224

@anthrotype
designspaceLib: add fromfile, fromstring and tostring methods
6cfa1a0
@anthrotype
varLib.designspace: add a deprecation warning
5f18441
@anthrotype
models: add piecewiseLinearMap function
8900505 
copied from fontTools.varLib._DesignspaceAxis._map static method.
I place it here since it is also used by varLib.mutator, so makes sense
to have a public function
@anthrotype
mutator: use piecewiseLinearMap instead of _DesignspaceAxis._map
c960a36
@anthrotype
designspaceLib: add asdict() method to descriptor objects
d8d8ed4 
useful when pretty-printting in the logger
@anthrotype
designspaceLib: add map_forward/backward methods to AxisDescriptor class
95f1909
@anthrotype
designspaceLib: only raise when 'No axis defined' when self._strictAx…
76ba93e 
…isNames=True (default)
@anthrotype
varLib: use designspaceLib instead of varLib.designspace
0f4bdf6 
and replace _DesignspaceAxis with AxisDescriptor
@anthrotype
designspaceLib: 'axes' element is required by DesignSpaceDocument, re…
8000
5457270 
…move fallback code
@anthrotype
interpolate_layout: use DesignSpaceDocument instead of varLib.designs…
8080690 
…pace
@anthrotype
Test: raise DesignSpaceDocumentError when no axes defined
3c59ffd
@anthrotype
travis: 'brew install python' on macOS, use generic py3 tox env
ac9790c 
formula is now named just 'python'.
For the homebrew version installed on Travis (which we don't
autoupdate) we *should* get python3.6 with this currently.

It might be the case that python3 is already installed on
Travis macOS image, but need to check.

We call tox with 'TOXENV=py3' so that when Travis updates its homebrew,
we'll get python3.7 automatically.

Finally, use virtualenv instead of venv on mac to fix tox bootstrapping issue

pypa/virtualenv#1051
pre-commit/pre-commit#631
https://travis-ci.org/fonttools/fonttools/jobs/427582922#L214

fixup
@anthrotype anthrotype merged commit b193bba into fonttools:master Sep 12, 2018
@anthrotype anthrotype deleted the varLib-designspace branch September 12, 2018 10:18
behdad
behdad reviewed Sep 14, 2018
View reviewed changes
Copy link
Member
@behdad behdad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Lib/fontTools/designspaceLib/__init__.py
@@ -346,6 +363,20 @@ def serialize(self):
map=self.map,
)

def map_forward(self, v):
from fontTools.varLib.models import piecewiseLinearMap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move import to top level?

@khaledhosny khaledhosny mentioned this pull request Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behdad behdad behdad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[varLib] Use designspaceLib instead of varLib.designspace
2 participants
@anthrotype @behdad
0