8000 [varLib] Use designspaceDocument? · Issue #911 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[varLib] Use designspaceDocument? #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brawer opened this issue Apr 8, 2017 · 8 comments
Closed

[varLib] Use designspaceDocument? #911

brawer opened this issue Apr 8, 2017 · 8 comments
Assignees
@behdad

Comments

@brawer
Copy link
Collaborator
brawer commented Apr 8, 2017

Should fontTools.varLib use @LettError’s designspaceDocument class?

  • Advantages: Nice API. Less duplication of code between font libraries, such as glyphsLib (which writes designspace) and varLib (which reads them). Files would always be spec-compliant.
  • Disadvantage: Our dependency hell gets worse, for a relatively minor piece.

Thoughts? Perhaps designspaceDocument coud become part of fonttools?
@anthrotype
Copy link
Member

+1 for using designspaceDocument, +2 for including it in fonttools if Erik steps up to maintain it

@davelab6
Copy link
Contributor
davelab6 commented Apr 9, 2017 via email

@brawer
Copy link
Collaborator Author
brawer commented Apr 9, 2017

Yes, they are.

@LettError
Copy link
Collaborator

If this is the way to go, I don't mind maintaining it.

@anthrotype
Copy link
Member

Thanks Erik! You already have push access, so you can create a new branch here on the fonttools repo where we work together on integrating the new subpackage into the library.
I guess it would go inside fontTools.varLib, replacing the current designspace.py. Or do we want to place it one level above, under fontTools.designspaceDocument?

@anthrotype
Copy link
Member

Maybe outside of varLib, as fontTools.designspaceDocument, would be better.

@behdad
Copy link
Member
behdad commented Apr 10, 2017

I like folding it in as well. Will review the code / api.

@belluzj belluzj mentioned this issue Nov 16, 2017
Merged
@anthrotype anthrotype mentioned this issue Nov 16, 2017
Open
@belluzj belluzj mentioned this issue Nov 22, 2017
Merged
@behdad behdad self-assigned this Feb 24, 2018
@khaledhosny
Copy link
Collaborator

Already done #1313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@behdad behdad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@khaledhosny @behdad @davelab6 @LettError @brawer @anthrotype
0