8000 Fix subtable break by moyogo · Pull Request #1302 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix subtable break #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Fix subtable break #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdf9690
feaLib tests: update PairPos subtable tests
moyogo Jul 26, 2018
18ad93f
feaLib: reset forceSubtableBreak_ to False
moyogo Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/fontTools/feaLib/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,6 +1499,7 @@ def flush_(self):
st = otl.buildPairPosClassesSubtable(self.values_,
self.builder_.glyphMap)
self.subtables_.append(st)
self.forceSubtableBreak_ = False


class PairPosBuilder(LookupBuilder):
Expand Down
1 change: 1 addition & 0 deletions Tests/feaLib/data/PairPosSubtable.fea
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ lookup kernlookup {
subtable;
pos @group1 @group2 -12;
subtable;
pos @group1 @group3 -10;
pos @group3 @group2 -20;
} kernlookup;

Expand Down
25 changes: 21 additions & 4 deletions Tests/feaLib/data/PairPosSubtable.ttx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,26 +84,43 @@
</PairPos>
<PairPos index="2" Format="2">
<Coverage>
<Glyph value="b"/>
<Glyph value="o"/>
<Glyph value="v"/>
<Glyph value="w"/>
</Coverage>
<ValueFormat1 value="4"/>
<ValueFormat2 value="0"/>
<ClassDef1>
<ClassDef glyph="b" class="1"/>
<ClassDef glyph="o" class="1"/>
</ClassDef1>
<ClassDef2>
<ClassDef glyph="c" class="1"/>
<ClassDef glyph="d" class="1"/>
<ClassDef glyph="c" class="2"/>
<ClassDef glyph="d" class="2"/>
<ClassDef glyph="v" class="1"/>
<ClassDef glyph="w" class="1"/>
</ClassDef2>
<!-- Class1Count=1 -->
<!-- Class2Count=2 -->
<!-- Class1Count=2 -->
<!-- Class2Count=3 -->
<Class1Record index="0">
<Class2Record index="0">
</Class2Record>
<Class2Record index="1">
</Class2Record>
<Class2Record index="2">
<Value1 XAdvance="-20"/>
</Class2Record>
</Class1Record>
<Class1Record index="1">
<Class2Record index="0">
</Class2Record>
<Class2Record index="1">
<Value1 XAdvance="-10"/>
</Class2Record>
<Class2Record index="2">
</Class2Record>
</Class1Record>
</PairPos>
</Lookup>
</LookupList>
Expand Down
0