8000 Fix subtable break by moyogo · Pull Request #1302 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix subtable break #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2018
Merged

Fix subtable break #1302

merged 2 commits into from
Jul 26, 2018

Conversation

moyogo
Copy link
Collaborator
@moyogo moyogo commented Jul 26, 2018

The PairPos subtable break was being forced after each 'pos' statement following a 'subtable' statement, it should only be forced the time.

moyogo added 2 commits July 26, 2018 11:06
@moyogo
feaLib tests: update PairPos subtable tests
fdf9690 
The subtable break is being forced after every pos, it shouldn’t.
@moyogo
feaLib: reset forceSubtableBreak_ to False
18ad93f
@moyogo moyogo requested a review from anthrotype July 26, 2018 10:08
@anthrotype
Copy link
Member

Thanks Denis! You're right, the state of the builder needed to be reset after building each subtables!

@anthrotype anthrotype merged commit 83f9156 into fonttools:master Jul 26, 2018
@moyogo moyogo deleted the fix-subtable-break branch August 8, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moyogo @anthrotype
0