8000 Consider account number uniquely identifying by oddstr13 · Pull Request #814 · firefly-iii/data-importer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consider account number uniquely identifying #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Consider account number uniquely identifying #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/Services/CSV/Conversion/Task/Accounts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,13 @@ private function findAccount(array $array, ?Account $defaultAccount): array
return $array;
}

// Return ID or number if not null
if ('' !== (string) $array['number']) {
app('log')->debug('At least the array with account-info has some account number info, return that.', $array);

return $array;
}

// if the default account is not NULL, return that one instead:
if (null !== $defaultAccount) {
4065 $default = $defaultAccount->toArray();
Expand Down
0