Consider account number uniquely identifying #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh. not sure what the dependabot commit is doing in the commit history |
When `findAccount` is provided with a default, and the account does not exist in the database, only provided `id`, `iban` or `name` are considered before falling back to using the default account. This change adds `number` to that list.
53f2be0 to
628cbcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix firefly-iii/firefly-iii#10387
When
findAccountis provided with a default, and the account does not exist in the database, only providedid,ibanornameare considered before falling back to using the default account.This change adds
numberto that list.