FIX adjust test precision to 1e-5 #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
romanlutz
pushed a commit
to romanlutz/fairlearn
that referenced
this pull request
Jul 6, 2021
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
romanlutz
pushed a commit
that referenced
this pull request
Jul 6, 2021
* DOC Extend documentation for plotting functionality (#806) * Extend documentation for plotting functionality Issue #802 * Use literalinclude instead of codeblock * Extend documentation for plotting functionality Issue #802 * Use literalinclude instead of codeblock * fix header underline and remove duplicate sections Signed-off-by: Roman Lutz <rolutz@microsoft.com> * avoid showing customized plot code in quickstart Signed-off-by: Roman Lutz <rolutz@microsoft.com> * Update docs/user_guide/assessment.rst Co-authored-by: Hilde Weerts <24417440+hildew 8000 eerts@users.noreply.github.com> * Update docs/user_guide/assessment.rst Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com> Co-authored-by: Roman Lutz <rolutz@microsoft.com> Co-authored-by: Roman Lutz <romanlutz13@gmail.com> Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com> * DOC: Change year dynamically in sphinx docs (#871) Signed-off-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com> Co-authored-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com> * DOC: Construct Validity Glossary (main) (#787) * PP Study - No flake8 issues besides those generated by Sphinx (line too long, blank line required between summary and description, missing docstring) Signed-off-by: Michael Amoako <miamoako@microsoft.com> * Message Signed-off-by: Michael Amoako <miamoako@microsoft.com> * Message Signed-off-by: Michael Amoako <miamoako@microsoft.com> * Message Signed-off-by: Michael Amoako <miamoako@microsoft.com> * Message Signed-off-by: Michael Amoako <miamoako@microsoft.com> * Message Signed-off-by: Michael Amoako <miamoako@microsoft.com> * Message Signed-off-by: Michael Amoako <miamoako@microsoft.com> * This is intended (romanlutz) * trying to build AI systems (hildeweerts) * new sociotechnical context definition (hildeweerts) * links where paper title referenced (romanlutz) * does->do (romanlutz) * the extent to which the measurement model measures the intended construct in way that is meaningful and useful (hildeweerts) * Updated: gap between fairness and demographic parityclosed, reference to fairlearn metrics fixed * Added related example of patient benefit (rolutz) * Pass through for initial commit * MM Requested change (intro) * DOC Remove redundant toctree in gallery header (#872) (#873) The left example navbar is now autogenerated by sphinx-gallery so leaving this section is causing duplicates in the navbar. * DOC Add note about MetricFrame CSV export (#875) * Fixing links Signed-off-by: Richard Edgar <riedgar@microsoft.com> * Rephrase and add a couple more details Signed-off-by: Richard Edgar <riedgar@microsoft.com> * Keep flake8 happy Signed-off-by: Richard Edgar <riedgar@microsoft.com> * FIX create utils module (#878) * version updates for 0.7.0 (#868) Signed-off-by: Roman Lutz <rolutz@microsoft.com> * add __init__.py file Signed-off-by: Roman Lutz <rolutz@microsoft.com> * create utils module with input validation Signed-off-by: Roman Lutz <rolutz@microsoft.com> * undo versioning changes Signed-off-by: Roman Lutz <rolutz@microsoft.com> * flake8 Signed-off-by: Roman Lutz <rolutz@microsoft.com> * Update fairlearn/reductions/_moments/utility_parity.py Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> * Update fairlearn/utils/__init__.py Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> * Update test/unit/postprocessing/test_threshold_optimization.py Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> * flake8 Signed-off-by: Roman Lutz <rolutz@microsoft.com> * flake8 Signed-off-by: Roman Lutz <rolutz@microsoft.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> * adjust precision to 1e-5 (#883) Signed-off-by: Roman Lutz <rolutz@microsoft.com> Co-authored-by: Brenda Thng <52529078+bthng@users.noreply.github.com> Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com> Co-authored-by: Kurian Benoy <kurian.bkk@gmail.com> Co-authored-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com> Co-authored-by: Michael Amoako <miamoako@microsoft.com> Co-authored-by: Fyrebright <aidcostello@gmail.com> Co-authored-by: Richard Edgar <riedgar@microsoft.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently failing in the
mainbranch on Mac OS with Python 3.7 (https://dev.azure.com/responsibleai/fairlearn/_build/results?buildId=12387&view=logs&j=0a22f5d8-9f3e-5735-4672-5a55fb1a2abf&t=4a75d996-b002-586d-ec0d-145d497c0466)As @MiroDudik pointed out in #882 this should be fixed by adjusting the precision to
1e-5instead of1e-6. Once this is merged we should cherry-pick it into #882 for the release v0.7.0Signed-off-by: Roman Lutz rolutz@microsoft.com