10000 FIX create utils module by romanlutz · Pull Request #878 · fairlearn/fairlearn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

FIX create utils module #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 29, 2021
Merged

Conversation

romanlutz
Copy link
Member

This adds an __init__.py file just like #877 on the release branch, but additionally moves other utilities (input validation) into the module. The move requires a few import adjustments which are also included.

Roman Lutz added 5 commits June 16, 2021 14:03
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
@romanlutz romanlutz added the bug Something isn't working label Jun 27, 2021
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits which you can ignore if you don't like the style, otherwise LGTM.

I'd cherry pick this for the branch rather than merging the other PR.

romanlutz and others added 6 commits June 28, 2021 12:10
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
Signed-off-by: Roman Lutz <rolutz@microsoft.com>
@romanlutz romanlutz merged commit c2893ed into fairlearn:main Jun 29, 2021
@romanlutz romanlutz deleted the rolutz/utils_module branch June 29, 2021 20:44
romanlutz pushed a commit to romanlutz/fairlearn that referenced this pull request Jul 2, 2021
* version updates for 0.7.0 (fairlearn#868)

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* add __init__.py file

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* create utils module with input validation

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* undo versioning changes

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* flake8

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* Update fairlearn/reductions/_moments/utility_parity.py

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* Update fairlearn/utils/__init__.py

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* Update test/unit/postprocessing/test_threshold_optimization.py

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* flake8

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* flake8

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
romanlutz pushed a commit that referenced this pull request Jul 6, 2021
* DOC Extend documentation for plotting functionality (#806)

* Extend documentation for plotting functionality

Issue #802

* Use literalinclude instead of codeblock

* Extend documentation for plotting functionality

Issue #802

* Use literalinclude instead of codeblock

* fix header underline and remove duplicate sections

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* avoid showing customized plot code in quickstart

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* Update docs/user_guide/assessment.rst

Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com>

* Update docs/user_guide/assessment.rst

Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com>

Co-authored-by: Roman Lutz <rolutz@microsoft.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com>

* DOC: Change year dynamically in sphinx docs (#871)

Signed-off-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com>

Co-authored-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com>

* DOC: Construct Validity Glossary (main)  (#787)

* PP Study - No flake8 issues besides those generated by Sphinx (line too long, blank line required between summary and description, missing docstring)

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* Message

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* Message

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* Message

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* Message

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* Message

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* Message

Signed-off-by: Michael Amoako <miamoako@microsoft.com>

* This is intended (romanlutz)

* trying to build AI systems (hildeweerts)

* new sociotechnical context definition (hildeweerts)

* links where paper title referenced (romanlutz)

* does->do (romanlutz)

* the extent to which the measurement model measures the intended construct in way that is meaningful and useful (hildeweerts)

* Updated: gap between fairness and demographic parityclosed, reference to fairlearn metrics fixed

* Added related example of patient benefit (rolutz)

* Pass through for initial commit

* MM Requested change (intro)

* DOC Remove redundant toctree in gallery header (#872) (#873)

The left example navbar is now autogenerated by sphinx-gallery so leaving this section  is causing duplicates in the navbar.

* DOC Add note about MetricFrame CSV export (#875)

* Fixing links

Signed-off-by: Richard Edgar <riedgar@microsoft.com>

* Rephrase and add a couple more details

Signed-off-by: Richard Edgar <riedgar@microsoft.com>

* Keep flake8 happy

Signed-off-by: Richard Edgar <riedgar@microsoft.com>

* FIX create utils module (#878)

* version updates for 0.7.0 (#868)

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* add __init__.py file

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* create utils module with input validation

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* undo versioning changes

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* flake8

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* Update fairlearn/reductions/_moments/utility_parity.py

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* Update fairlearn/utils/__init__.py

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* Update test/unit/postprocessing/test_threshold_optimization.py

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* flake8

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

* flake8

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>

* adjust precision to 1e-5 (#883)

Signed-off-by: Roman Lutz <rolutz@microsoft.com>

Co-authored-by: Brenda Thng <52529078+bthng@users.noreply.github.com>
Co-authored-by: Hilde Weerts <24417440+hildeweerts@users.noreply.github.com>
Co-authored-by: Kurian Benoy <kurian.bkk@gmail.com>
Co-authored-by: kurianbenoy-aot <kurian.benoy@aot-technologies.com>
Co-authored-by: Michael Amoako <miamoako@microsoft.com>
Co-authored-by: Fyrebright <aidcostello@gmail.com>
Co-authored-by: Richard Edgar <riedgar@microsoft.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0